Skip to content

Premium Analytics: expand the feedback confirmation message - #52107

Merged
chihsuan merged 1 commit into
trunkfrom
change/uni-758-feedback-confirmation
Sep 9, 2026
Merged

Premium Analytics: expand the feedback confirmation message#52107
chihsuan merged 1 commit into
trunkfrom
change/uni-758-feedback-confirmation

Conversation

@chihsuan

@chihsuan chihsuan commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes UNI-758

Proposed changes

  • Replace the post-submit confirmation in the Stats v2 feedback modal, which read "Thank you. This helps.", with copy that says where the feedback went and what it is used for.
  • Render it as a Notice.Title plus a Notice.Description so the headline and the explanation read as two parts.
  • Cover both sentences in the options-menu tests, on the success path and on the endpoint-failure path.

The copy is Gary's from UNI-758, with a comma added to the first line ("Thanks, your feedback has gone to the team.") because the issue text was missing one.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No. The submission path is untouched: the same Tracks event fires, and a non-empty comment still reaches the Stats feedback endpoint.

Testing instructions

  1. Open Stats v2 on a connected site: Stats v2 in the admin menu.
  2. Open the page options menu (the three dots at the top right) and pick Any feedback?.
  3. Pick any rating and press Send feedback.
  4. The success notice should read "Thanks, your feedback has gone to the team." in bold, followed by "It'll help us decide what to fix before the new Traffic tab replaces the old one. You can send more any time from the same menu."
  • Done should still close the modal, and reopening the menu should let you send feedback again.

Note: Step 3 sends a real submission. The dashboard does not pass is_testing, so a comment reaches Happiness and opens a Zendesk ticket. Either add is_testing: true to the body in submitStatsUserFeedback while you test, or resolve the ticket afterwards.

Feedback confirmation notice

@chihsuan chihsuan self-assigned this Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the change/uni-758-feedback-confirmation branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack change/uni-758-feedback-confirmation

bin/jetpack-downloader test jetpack-mu-wpcom-plugin change/uni-758-feedback-confirmation

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions Bot added [Package] Premium Analytics [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Premium Analytics labels Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: October 6, 2026

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Premium Analytics plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@chihsuan
chihsuan marked this pull request as ready for review September 9, 2026 02:53
@chihsuan
chihsuan requested a review from a team as a code owner September 9, 2026 02:53
@chihsuan chihsuan added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Sep 9, 2026
@chihsuan chihsuan changed the title UNI-758: Premium Analytics: expand the feedback confirmation message Premium Analytics: expand the feedback confirmation message Sep 9, 2026
@jp-launch-control

jp-launch-control Bot commented Sep 9, 2026

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Nikschavan
Nikschavan approved these changes Sep 9, 2026
View reviewed changes

@Nikschavan Nikschavan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the changes look good.

dognose24
dognose24 approved these changes Sep 9, 2026
View reviewed changes

@dognose24 dognose24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Copy matches UNI-758, Notice.Title is available in @wordpress/ui 0.21, and both the success and endpoint-failure paths are covered in the tests.

@chihsuan
chihsuan merged commit 6083348 into trunk Sep 9, 2026
89 of 90 checks passed
@chihsuan
chihsuan deleted the change/uni-758-feedback-confirmation branch September 9, 2026 06:40
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nikschavan Nikschavan Nikschavan approved these changes
@dognose24 dognose24 dognose24 approved these changes

Assignees

@chihsuan chihsuan

Labels

[Package] Premium Analytics [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Premium Analytics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chihsuan @Nikschavan @dognose24